5

Keep encoding attributes for closures by oli-obk · Pull Request #111381 · rust-l...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/111381
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Keep encoding attributes for closures #111381

Conversation

Contributor

see model-checking/kani#2406 (comment) for some context.

We stopped encoding attributes for closures, but some tools need them

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

May 9, 2023

Contributor

Author

This comment has been minimized.

rustbot

added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

May 9, 2023

Contributor

hourglass Trying commit b7f570f with merge 4a8c1cb...

Contributor

sunny Try build successful - checks-actions
Build commit: 4a8c1cb (4a8c1cbfc300556b9130d68a4f77987a8bff5403)

This comment has been minimized.

Collaborator

Finished benchmarking commit (4a8c1cb): comparison URL.

Overall result: white_check_mark improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)
- - 0
Regressions x
(secondary)
- - 0
Improvements white_check_mark
(primary)
- - 0
Improvements white_check_mark
(secondary)
-0.3% [-0.3%, -0.2%] 2
All xwhite_check_mark (primary) - - 0

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 656.874s -> 655.684s (-0.18%)

rustbot

removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

May 9, 2023

Contributor

Author

Contributor

@bors r+ rollup

Contributor

pushpin Commit b7f570f has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

May 9, 2023

bors

merged commit 3d4d670 into

rust-lang:master

May 10, 2023

12 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

May 10, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK