Tweak borrow suggestion span by compiler-errors · Pull Request #110504 · rust-la...
source link: https://github.com/rust-lang/rust/pull/110504
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
Avoids a span_to_snippet call when we don't need to surround the expression in parentheses. The fact that the suggestion was using the whole span of the expression rather than just appending a & was prevented me from using // run-rustfix in another PR (#110432 (comment)).
Also some drive-by renames of functions that have been annoying me for a bit.
Collaborator
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Contributor
|
Could you completely remove the span_to_snippet call by making the suggestion multipart? |
Member
Author
|
I could, but that would require a bit more work, since this function currently has a very strange API: I guess I'll look into it. |
Contributor
|
@bors r+ |
Commit Contributor
|
|
The tree is currently added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Member
Author
|
rebased @bors r=cjgillot |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
|
|
The latest upstream changes (presumably removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label
added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label
Member
Author
|
rebased again @bors r=cjgillot |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK