8

try running on windows by tompscanlan · Pull Request #13042 · rust-lang/cargo ·...

 9 months ago
source link: https://github.com/rust-lang/cargo/pull/13042
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

What does this PR try to resolve?

Try getting rustfix tests to run on windows and fix #13033

How should we test and review this PR?

CI should catch failure. Look out for flaky tests in the long run.

Additional information

tested briefly on win11.

Collaborator

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added Command-fix

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 23, 2023

Member

@weihanglo weihanglo

left a comment

Sounds like a reasonable step forward. It might or might not fail when updating cargo submodule in rust-lang/rust but we'll see.

Member

CI is green. Thank you

@bors r+

Collaborator

📌 Commit e9e22e5 has been approved by weihanglo

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 24, 2023

Collaborator

⌛ Testing commit e9e22e5 with merge 527b35e...

Collaborator

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 527b35e to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

weihanglo

weihanglo approved these changes
Assignees

epage

Labels
Command-fix S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

rustfix: Fix Windows tests

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK