[FEATURE] move redis key creation to a common module · Issue #917 · juspay/hyper...
source link: https://github.com/juspay/hyperswitch/issues/917
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
[FEATURE] move redis key creation to a common module #917
2 tasks done
Narayanbhat166 opened this issue Apr 19, 2023 · 13 comments
Comments
Feature DescriptionFew entities currently are stored in redis. We create a key for each entity. This key will be usually of the form Possible ImplementationThere can be a module that exports functions for each of the key creation. This function takes the dynamic variables ( like
One may also think about using enums for this. Have you spent some time to check if this feature request has been raised before?
Have you read the Contributing Guidelines?
Are you willing to submit a PR?No, but I'm happy to collaborate on a PR with someone else |
added C-feature Category: Feature request or enhancement good first issue Good for newcomers help wanted Extra attention is needed
labels
🙋🏻♂️I'd like to draft a solution for this issue for you . I suspect based on the criteria that there could be quite a bit of workshopping involved to iron this out, but I thrive on feedback and would enjoy that greatly. I have read the contribution guidelines |
Hey @IsaacCloos, I've assigned this issue to you. |
Member
Author
Thanks @IsaacCloos for showing interest. Yes that would be great. We can discuss about the implementation. |
Contributor
I am interested in collaborating with someone on their project so I can learn the language while they get a sidekick. |
I'm sorry for the delay! I have become busy with work and juggling a few other issues. Please feel free to reassign this issue as you see fit since I noticed it hasn't been labeled as low priority. I don't want to hold up any work by squatting on it. I see @EliKalter is showing interest 👀 I'd be happy to share my experience with setting up the project for local development and testing if somebody else gets stuck |
Contributor
Thanks @IsaacCloos , I appreciate the response, Honestly I'm not sure it was a good idea for me to offer help because I've never contributed to an open source before (so I'd need help with the most basic of tasks in that regard) nor do I know rust even remotely well (so I'd need help on that from as well), I'm thinking maybe I should learn rust better by myself and start contributing on other beginner friendly projects first and get back to contributing to rust projects some day down the line, what are your thoughts? |
added E-easy Effort: Should be easy to implement and would make a good first PR P-low Priority: Low C-refactor Category: Refactor
and removed C-feature Category: Feature request or enhancement
labels
Member
@IsaacCloos No problem, we understand that contributors have a personal life, and contribute to our project during their free time and out of their own interest, not due to obligation.
I'm sorry for the confusion, this is indeed a low priority refactor and does not block any of our work. It's a good-to-have change, and not an immediate necessity. I've updated the labels on this issue to reflect the same. Let us know if you're still interested in taking a look at this, we'll help @EliKalter with any of the other issues they've expressed their interest on. |
Member
Folks being new to Rust and/or open source contributions is completely fine with us. We all started somewhere. Among the issues you expressed your interest on, #899 seems to be a pretty simple change. I can assign it to you and you can work on it at your own pace. Would that work for you? Feel free to ask any more questions you may have on that thread. |
Contributor
Thanks @SanchithHegde , I assume this thread is being taken care of by @IsaacCloos and that's way you suggested #899?! |
Member
I suggested #899 since we're not yet sure if @IsaacCloos would take this one up. |
added S-unassigned Status: This issue has no one assigned to address it
and removed S-unassigned Status: This issue has no one assigned to address it
labels
@EliKalter I'll be assigning this to you, as discussed over Discord. |
@EliKalter Please let us know if you're still working on this issue or still interested in working on it. There hasn't been any recent activity on this thread, or any open PRs. We hope to hear from you by the end of June 2023, or we'll open this for other contributors to pick up. |
Member
I'll be opening this issue for other contributors to pick up. |
added S-unactionable Status: There is not enough information to act on this problem S-unassigned Status: This issue has no one assigned to address it
and removed S-unactionable Status: There is not enough information to act on this problem
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No one assigned
None yet
No milestone
No branches or pull requests
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK