3

Private-in-public lints implementation by Bryanskiy · Pull Request #111801 · rus...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/111801
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Private-in-public lints implementation #111801

Merged

Conversation

Contributor

Contributor

Author

@rustbot author

rustbot

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

May 20, 2023

This comment has been minimized.

clubby789

removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

May 20, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Contributor

Author

@rustbot ready

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 25, 2023

This comment has been hidden.

petrochenkov

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

May 29, 2023

petrochenkov

added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 9, 2023

This comment has been minimized.

This comment has been minimized.

rustbot

added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label

Jun 11, 2023

Contributor

hourglass Trying commit 1c74edd with merge 36c03d7...

Contributor

sunny Try build successful - checks-actions
Build commit: 36c03d7 (36c03d72fa8b8bf825de72a5154565aa26707d18)
1 similar comment

This comment has been minimized.

Collaborator

Finished benchmarking commit (36c03d7): comparison URL.

Overall result: x regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)		 0.2% [0.2%, 0.2%] 5
Regressions x
(secondary)		 0.3% [0.2%, 0.4%] 4
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 - - 0
All xwhite_check_mark (primary) 0.2% [0.2%, 0.2%] 5

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.255s -> 647.39s (0.02%)

rustbot

added perf-regression Performance regressions

and removed S-waiting-on-perf Status: Waiting on a perf run to be completed.

labels

Jun 11, 2023

Contributor

r=me after extending the comment in #111801 (comment) and squashing commits.

Contributor

@bors r+ rollup=maybe

Contributor

pushpin Commit 6d46382 has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jun 11, 2023

Contributor

hourglass Testing commit 6d46382 with merge 77dba22...

Contributor

sunny Test successful - checks-actions
Approved by: petrochenkov
Pushing 77dba22 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Jun 12, 2023

bors

merged commit 77dba22 into

rust-lang:master

Jun 12, 2023

12 checks passed

Collaborator

Finished benchmarking commit (77dba22): comparison URL.

Overall result: x regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)		 0.2% [0.1%, 0.2%] 3
Regressions x
(secondary)		 0.6% [0.2%, 1.1%] 3
Improvements white_check_mark
(primary)		 - - 0
Improvements white_check_mark
(secondary)		 - - 0
All xwhite_check_mark (primary) 0.2% [0.1%, 0.2%] 3

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.784s -> 647.92s (-0.44%)

Member

  • primary regressions were to stm32f4-0.14.0 check+opt incr, but by a really small amount (0.18%).
  • marking as triaged.

@rustbot label: +perf-regression-triaged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petrochenkov

petrochenkov left review comments
Labels
merged-by-bors This PR was explicitly merged by bors perf-regression Performance regressions perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

None yet

8 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK