6
fix: fetch nested git submodules by krs98 · Pull Request #12244 · rust-lang/carg...
source link: https://github.com/rust-lang/cargo/pull/12244
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
What does this PR try to resolve?
Fixes #12151.
When recursing submodules, the url of the parent remote was being passed to update_submodules instead of the child remote url. This caused Cargo to try to add the wrong submodule.
How should we test and review this PR?
A test case is added in the first commit. The second one renames the url variable as suggested in the issue. The third includes the changes to fix the issue. The last one includes a minor refactor where a redundant match expr is removed.
weihanglo reacted with thumbs up emojiLazyGeniusMan reacted with hooray emoji
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK