Normalize types and consts in MIR opts. by cjgillot · Pull Request #110714 · rus...
source link: https://github.com/rust-lang/rust/pull/110714
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Normalize types and consts in MIR opts. #110714
Conversation
Contributor
Some passes were using a non-RevealAll param_env, which is needlessly restrictive in mir-opts.
As a drive-by, we normalize all constants, since just normalizing their types is not enough.
Collaborator
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Contributor
This comment has been minimized.
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Trying commit Contributor
|
|
Try build successful - This comment has been minimized.
Collaborator
|
Finished benchmarking commit (29598da): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
0.3% | [0.3%, 0.3%] | 1 |
Improvements  (primary) |
- | - | 0 |
| Improvements (secondary) |
- | - | 0 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
Results
removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
|
@bors r+ rollup |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
@cjgillot can we also run the |
Contributor
Author
|
I thought it was already on by default |
. No reason we shouldn't.Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK