Track if EvalCtxt has been tainted, make sure it can't be used to make query res...
source link: https://github.com/rust-lang/rust/pull/110618
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Just some additional protection against missing probes or strange candidate assembly behavior in the new solver.
For background, we don't ever want to call evaluate_added_goals_and_make_canonical_response
if a previous call to try_evaluate_added_goals
has bailed with NoSolution
, since our nested goals are left in an undefined state at that point. This most commonly suggests a missing EvalCtxt::probe
, but could also signify some other shenanigans like dropping a QueryResult
on the floor without properly ?
'ing it.
r? @lcnr
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK