4

Give opaque types a better coherence error by oli-obk · Pull Request #106010 · r...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/106010
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

@oli-obk oli-obk commented Dec 21, 2022

No description provided.

Globidev reacted with heart emoji

Collaborator

rustbot commented Dec 21, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon.

Please see the contribution instructions for more information.

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 21, 2022

ty::Slice(_) => (this, " because slices are always foreign"),

ty::Array(..) => (this, " because arrays are always foreign"),

ty::Tuple(..) => (this, " because tuples are always foreign"),

let msg = |ty: &str, postfix: &str| {

the variable names here are kinda confusing (msg, this, msg), but w/e

Contributor

bors commented Dec 22, 2022

pushpin Commit a9af75c has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Dec 22, 2022

bors

merged commit d4aca6b into

rust-lang:master

Dec 22, 2022

10 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Dec 22, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK