Trying commit b85a28f with merge 9490fcf...

Try build successful - checks-actions
Build commit: 9490fcf (9490fcf9c4ecf3ed0b3ae1a007f2f8e5b26d5692)

Finished benchmarking commit (9490fcf): comparison URL.

Overall result: regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Warning : The following benchmark(s) failed to build:

• rustc

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.9%	[0.3%, 2.8%]	29
Regressions (secondary)	1.5%	[1.0%, 2.0%]	7
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.9%	[0.3%, 2.8%]	29

Max RSS (memory usage)

Results

Cycles

Results

@lcnr told me r=me on Zulip after updating the tracking issue (#105572) to be more descriptive.

We also discussed this during the compiler team meeting (starting here) and decided the perf hit is acceptable, as this lint will be removed and turned into a hard error hopefully in a few versions.

@bors r=lcnr

Commit 49176ab has been approved by lcnr

It is now in the queue for this repository.

Testing commit 49176ab with merge c09c28b...

Test failed - checks-actions

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@bors r=lcnr lol let's try this again

Trying commit 8c86773 with merge 71f9b2b...

Try build successful - checks-actions
Build commit: 71f9b2b (71f9b2b2c40fc783c579b616d23eda44f74eeff1)

Finished benchmarking commit (71f9b2b): comparison URL.

Overall result: regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.8%	[0.2%, 2.3%]	23
Regressions (secondary)	1.5%	[0.7%, 2.6%]	13
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.8%	[0.2%, 2.3%]	23

Max RSS (memory usage)

Results

Cycles

Results

Huh, well, seems like rewriting it to only try once on the good path didn't actually fix the perf. Anyways, oli told me r=me on PM.

@bors r=oli-obk rollup=never

Commit 8c86773 has been approved by oli-obk

It is now in the queue for this repository.

Testing commit 8c86773 with merge 7f42e58...

Test successful - checks-actions
Approved by: oli-obk
Pushing 7f42e58 to master...

Finished benchmarking commit (7f42e58): comparison URL.

Overall result: regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean	range	count
Regressions (primary)	0.9%	[0.2%, 2.3%]	20
Regressions (secondary)	1.6%	[0.6%, 2.6%]	12
Improvements (primary)	-	-	0
Improvements (secondary)	-	-	0
All (primary)	0.9%	[0.2%, 2.3%]	20

Max RSS (memory usage)

Results

Cycles

Results

@rustbot label: +perf-regression-triaged

This regression was anticipated and accepted by the compiler team and types team on the grounds that we'll get this perf back once the future incompat lint becomes a hard error.

Also: this addresses a soundness issue

I'm going to add relnotes here. It's not certain at what stage this lint will be (still warn or upgraded to deny) at release time, but given the size of breakages reported by crater, I think it would be good to point this out.

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@compiler-errors This doesn't seem to backport cleanly -- can you prepare a PR targeting the beta branch?