6
Migrate rustc_monomorphize to use SessionDiagnostic by CleanCut · Pull Request #...
source link: https://github.com/rust-lang/rust/pull/100730
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Description
- Migrates diagnostics in
rustc_monomorphizeto useSessionDiagnostic - Adds an
impl IntoDiagnosticArg for PathBuf
TODO / Help!
-
I'm having trouble figuring out how to apply an optional note.
Help!?
- Resolved. It was bad docs. Fixed in https://github.com/rust-lang/rustc-dev-guide/pull/1437/files
-
errors:RecursionLimitshould be#[fatal ...], but that doesn't exist so it's#[error ...]at the moment.- Maybe I can switch after this is merged in? --> Migrate rustc_ast_passes diagnostics to
SessionDiagnosticand translatable messages (first part) #100694 - Or maybe I need to manually implement
SessionDiagnosticinstead of deriving it?
- Maybe I can switch after this is merged in? --> Migrate rustc_ast_passes diagnostics to
- How does one go about converting an error inside of a call to struct_span_lint_hir?
-
What placeholder do you use in the fluent template to refer to the value in a vector? It seems like this code ought to have the answer (or something near it)...but I can't figure it out.You can't. Punted.
All reactions
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK