2

Avoid needless buffer zeroing in `std::sys::windows::fs` by thomcc · Pull Reques...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/101236
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Avoid needless buffer zeroing in std::sys::windows::fs #101236

Conversation

Member

@thomcc thomcc commented 8 days ago

Followup to #101171 and #101193. This finishes up avoiding buffer zeroing pointed out in #100729 (comment) (thanks!)

r? @ChrisDenton

All reactions

rustbot

added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label

8 days ago

rust-highfive

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

8 days ago

thomcc

added the O-windows Operating system: Windows label

8 days ago

rustbot

added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label

8 days ago

thomcc

removed the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label

8 days ago

Member

Author

thomcc commented 8 days ago

edited

I ran windows tests in CI since I wrote this on a Mac. These passed, so I've dropped the commit. It should be fine to review now.

Contributor

ChrisDenton commented 8 days ago

@bors r+ rollup

Contributor

bors commented 8 days ago

pushpin Commit 14dd33b has been approved by ChrisDenton

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

8 days ago

bors

merged commit 3da66f0 into

rust-lang:master

8 days ago

20 checks passed

rustbot

added this to the 1.65.0 milestone

8 days ago

thomcc

deleted the winfs-nozero branch

8 days ago

rust-timer

added a commit to rust-lang-ci/rust that referenced this issue

8 days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK