Fix mem leak regression with Windows' sids API by mike-myers-tob · Pull Request...
source link: https://github.com/osquery/osquery/pull/6984
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Closes #6979 fixing a small regression introduced in #6782 that undid part of #6714
It's easy to forget to free memory with "Caller must free this parameter" APIs like ConvertStringSidToSidA, fixed before in #6714 (we even forgot to do it in the wrapper we created for ConvertSidToSidStringA, see #6548 that fixed that).
Because a wrapper for ConvertSidToSidStringA, I found one place that I changed to use that, instead of the raw API, saving a few lines of code. But in the future, to avoid similar problems with ConvertStringSidToSidA, we'd have to make our own wrapper class for sid that implemented RAII as noted by @Breakwell.
Recommend
-
4
New issue Spellcheck and Markdown nits #6899
-
2
Conversation As confirmed recently with @Smjert on Slack, the docs needed to be cha...
-
3
Conversation Users trying to simply turn on evented tables on Windows are often confused that --disable_events=false
-
5
Conversation Following up on
-
4
Conversation This PR fixes misspellings throughout the code, although almost all of them are in comments. In a couple of places I also fixed the spelling of what was clearly a typo in a code symbol....
-
4
Copy link Member mike-myers-tob ...
-
4
Conversation Closes issue #7319 I think the code comment and th...
-
2
Copy link Contributor
-
7
Conversation Should be an easy merge, I just fixed a few typos that were always staring at me when I opened new issues. And where a...
-
3
Conversation Recently in the osquery Slack, a user with Black Duck Software has shared a security audit report that it generates. One of the things it is flagging is an outdated version of lz4...
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK