7

the unadjusted ABI needs to pass aggregates by-value by RalfJung · Pull Request...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/118127
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

the unadjusted ABI needs to pass aggregates by-value #118127

Conversation

Member

Fixes #118124, a regression introduced in #117500

TimDiekmann reacted with heart emoji

Collaborator

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

Member

Could you just add a test that uses the NEON intrinsic and ensures it doesn't fail to compile?

Member

Author

I can probably do a no_core test that works on all hosts...

Member

Is the unadjusted ABI marked as internal feature? If not I think we should mark it as such.

Member

Author

Could you just add a test that uses the NEON intrinsic and ensures it doesn't fail to compile?

I added a test.

Member

Author

@davidtwco or anyone else from @rust-lang/compiler , this fixes a critical codegen regression, would be good to land it ASAP. :)

compiler-errors reacted with thumbs up emoji

@bors r+ rollup=never p=1

easier to bisect that way

Contributor

📌 Commit ebfb95a has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 25, 2023

Contributor

⌛ Testing commit ebfb95a with merge 16087ee...

Contributor

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 16087ee to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Nov 25, 2023

bors

merged commit 16087ee into

rust-lang:master

Nov 25, 2023

12 checks passed

Collaborator

Finished benchmarking commit (16087ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.133s -> 674.958s (-0.03%)
Artifact size: 313.36 MiB -> 313.33 MiB (-0.01%)

RalfJung

deleted the unadjusted-abi branch

November 27, 2023 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

No reviews

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

8 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK