the unadjusted ABI needs to pass aggregates by-value by RalfJung · Pull Request...
source link: https://github.com/rust-lang/rust/pull/118127
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
the unadjusted ABI needs to pass aggregates by-value #118127
Conversation
Collaborator
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
Member
Could you just add a test that uses the NEON intrinsic and ensures it doesn't fail to compile? |
Member
Author
I can probably do a no_core test that works on all hosts... |
Member
Is the unadjusted ABI marked as internal feature? If not I think we should mark it as such. |
Member
Author
I added a test. |
Member
Author
@davidtwco or anyone else from @rust-lang/compiler , this fixes a critical codegen regression, would be good to land it ASAP. :) |
@bors r+ rollup=never p=1 easier to bisect that way |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
☀️ Test successful - checks-actions |
Collaborator
Finished benchmarking commit (16087ee): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.133s -> 674.958s (-0.03%) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK