4

Tighten up link attributes for llvm-wrapper bindings by saethlin · Pull Request...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/118142
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Tighten up link attributes for llvm-wrapper bindings #118142

Conversation

Member

Fixes #118084 by moving all of the declarations of symbols from llvm_rust into a separate extern block with #[link(name = "llvm-wrapper", kind = "static")].

This also renames LLVMTimeTraceProfiler* to LLVMRustTimeTraceProfiler* because those are functions from llvm_rust.

r? tmiasko

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 21, 2023

Contributor

@bors r+

Contributor

📌 Commit e6f8edf has been approved by tmiasko

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 21, 2023

bors

merged commit dd9f3ad into

rust-lang:master

Nov 22, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Nov 22, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

No reviews

Assignees

tmiasko

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

LLVMRust symbols not defined when building with -Zcross-crate-inline-threshold=always

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK