3

Migrate `rustc_hir_analysis` to session diagnostic [Part 5] by obeis · Pull Requ...

 11 months ago
source link: https://github.com/rust-lang/rust/pull/115821
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

Finishing coherence/builtin.rs file

Collaborator

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 13, 2023

Contributor

☔ The latest upstream changes (presumably #115853) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

Author

rustbot

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Sep 16, 2023

obeis

force-pushed the hir-analysis-migrate-diagnostics-5

branch 3 times, most recently from dd79ee6 to a5ccb35 Compare

September 18, 2023 09:36

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 18, 2023

compiler-errors

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Sep 18, 2023

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Sep 20, 2023

Contributor

📌 Commit 77e205a has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Sep 28, 2023

Contributor

⌛ Testing commit 77e205a with merge 958c2b8...

Contributor

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 958c2b8 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Sep 29, 2023

bors

merged commit 958c2b8 into

rust-lang:master

Sep 29, 2023

12 checks passed

Collaborator

Finished benchmarking commit (958c2b8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.219s -> 630.657s (-0.09%)
Artifact size: 317.31 MiB -> 317.28 MiB (-0.01%)

obeis

deleted the hir-analysis-migrate-diagnostics-5 branch

September 29, 2023 08:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

compiler-errors

compiler-errors requested changes
Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.74.0

Development

Successfully merging this pull request may close these issues.

None yet

6 participants

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK