Do not lint when imported item contains underscore by koka831 · Pull Request #10...
source link: https://github.com/rust-lang/rust-clippy/pull/10300
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Do not lint when imported item contains underscore #10300
Merged
Conversation
Contributor
fix #9942
changelog: [wildcard_imports]: No longer lints when imported items contain an item with the name _
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Member
|
Hey, I've seen this PR, but had a pretty busy week so far. I'll review this tomorrow or on Friday, the latest! :) |
added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
labels
Member
|
I'm closing this PR due to inactivity. Hope you'll get better soon @koka831! Anyone else reading this, feel free to continue this PR. I believe it was only one or two questions remaining. |
added S-inactive-closed Status: Closed due to inactivity
and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
labels
This version looks good to me. Could you please rebase on master? Then we can r+ this version. You can also create a new PR with these changes if that's easier than a rebase :)
Contributor
Author
|
@xFrednet thank you for your comment. now I think I've addressed them. could you review again please? |
Member
|
Looks good to me, thank you for coming back and updating this PR :D |
added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
and removed S-inactive-closed Status: Closed due to inactivity
labels
Member
|
@bors r+ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK