9

Only prevent field projections into opaque types, not types containing opaque ty...

 11 months ago
source link: https://github.com/rust-lang/rust/pull/116156
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Only prevent field projections into opaque types, not types containing opaque types #116156

Conversation

Contributor

fixes #115778

I did not think that original condition through properly... I'll also need to check the similar check around the other ProjectionKind::OpaqueCast creation site (this one is in hir, the other one is in mir), but I'll do that change in another PR that doesn't go into a beta backport.

oli-obk

added the beta-nominated Nominated for backporting to the compiler in the beta channel. label

Sep 25, 2023

Collaborator

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Sep 25, 2023

Contributor

📌 Commit 17b313f has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Sep 25, 2023

Contributor

⌛ Testing commit 17b313f with merge e1636a0...

Contributor

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e1636a0 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Sep 27, 2023

bors

merged commit e1636a0 into

rust-lang:master

Sep 27, 2023

12 checks passed

Collaborator

Finished benchmarking commit (e1636a0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.857s -> 630.538s (-0.21%)
Artifact size: 317.04 MiB -> 317.11 MiB (0.02%)

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

rustbot

added the beta-accepted Accepted for backporting to the compiler in the beta channel. label

Sep 28, 2023

cuviper

removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label

Sep 29, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

compiler-errors

compiler-errors approved these changes
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

regression: as_place unwrap None

8 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK