2

Remove rustc-workspace-hack by ehuss · Pull Request #5776 · rust-lang/rustfmt ·...

 1 year ago
source link: https://github.com/rust-lang/rustfmt/pull/5776
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

The rustc-workspace-hack dependency was removed in rust-lang/rust#109133 and should no longer be needed.

Thank you for this. Are you fairly confident this removal won't cause any issues and/or have we tested in r-l/rust? Seems like it should be fine given the upstream context, just would hate to have this cause some breakage we don't discover till we're on the last leg of a subtree sync

Contributor

Author

Yea, I am confident there shouldn't be any issues. rustc-workspace-hack is an empty dependency which doesn't do anything. All the rust-lang/rust infrastructure for it has been removed.

calebcartwright reacted with thumbs up emoji

calebcartwright

merged commit e903fcd into

rust-lang:master

Jun 12, 2023

27 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

calebcartwright

calebcartwright approved these changes
Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

2 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK