5

Add deprecation warning to python versions <3.6 in x.py by tgross35 · Pull Re...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/112483
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Add deprecation warning to python versions <3.6 in x.py #112483

Conversation

Contributor

Introduced based on conversation on Zulip. This is a repeat of #110439 with two changes:

  • Warning rather than exit
  • Can be suppressed via an environment variable

The min to not get the warning is set to 3.6 because that's a fairly recent "old" version (went EOL in 2021) and it's the first version to support useful modern features like f-strings and type hints.

cc @Nilstrieb (author of #110439) and @Mark-Simulacrum (reviewer of that PR)

Collaborator

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 10, 2023

Contributor

Author

We could also create a dedicated issue for python version issues and link that in the error message.

I'm OK with this, and not sure that the env variable is entirely useful, but seems fine to keep it.

We can revisit this if there are concerns or we encounter too many warnings in practice.

@bors r+ rollup

Contributor

pushpin Commit cec95d7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jun 10, 2023

Contributor

Author

I'm OK with this, and not sure that the env variable is entirely useful, but seems fine to keep it.

I think I may have misunderstood your comment #110439 (comment) since you can disable warning.warn() warnings. But agreed it's probably fine to have an explicit option

bors

merged commit 68e162d into

rust-lang:master

Jun 10, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Jun 10, 2023

tgross35

deleted the py2-dep-warning branch

June 10, 2023 18:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK