0

Respect `RUST_BACKTRACE` for delayed bugs by Nilstrieb · Pull Request #112359 ·...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/112359
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Member

Sometimes, especially with MIR validation, the backtraces from delayed bugs are noise and make it harder to look at them. Respect the environment variable and don't print it when the user doesn't want it.

Collaborator

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 6, 2023

Member

Author

it worked when i tested it at first but now it doesn't work again, somethings wrong

Nilstrieb

marked this pull request as draft

June 6, 2023 19:28

Nilstrieb

marked this pull request as ready for review

June 6, 2023 19:34

Member

Author

it works just fine, i just held it wrong.
example:

error: internal compiler error: broken MIR in Item(DefId(0:21 ~ uwu[d045]::{impl#0}::deserialize)) (after pass PreCodegen) at bb0[1]:
                                Field projection `(*_2).0` specified type `u32`, but actual type is `<[<T as Archive>::Archived] as ArchivePointee>::ArchivedMetadata`
  --> uwu.rs:21:57
   |
21 |     let _a: <[T] as ArchivePointee>::ArchivedMetadata = v.metadata;
   |                                                         ^^^^^^^^^^
   |
   = note: delayed at compiler/rustc_const_eval/src/transform/validate.rs:354:30 - disabled backtrace

error: internal compiler error: broken MIR in Item(DefId(0:21 ~ uwu[d045]::{impl#0}::deserialize)) (after phase change to runtime-optimized) at bb0[1]:
                                Field projection `(*_2).0` specified type `u32`, but actual type is `<[<T as Archive>::Archived] as ArchivePointee>::ArchivedMetadata`
  --> uwu.rs:21:57
   |
21 |     let _a: <[T] as ArchivePointee>::ArchivedMetadata = v.metadata;
   |                                                         ^^^^^^^^^^
   |
   = note: delayed at compiler/rustc_const_eval/src/transform/validate.rs:354:30 - disabled backtrace

Member

@compiler-errors compiler-errors

left a comment

r=me if ci is green

Member

Author

@bors r=compiler-errors
ci is green

Contributor

pushpin Commit 7098092 has been approved by compiler-errors

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jun 6, 2023

bors

merged commit 1dc4b40 into

rust-lang:master

Jun 7, 2023

11 checks passed

rustbot

added this to the 1.72.0 milestone

Jun 7, 2023

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Jun 7, 2023

Nilstrieb

deleted the i-can-only-handle-so-many-backtraces branch

June 7, 2023 18:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

compiler-errors

compiler-errors approved these changes
Assignees

oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.72.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK