5

When hovering a PiP button while fullscreen, it will remain displayed while the...

 1 year ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1819701
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client
Closed Bug 1819701 Opened 2 months ago Closed 9 days ago

When hovering a PiP button while fullscreen, it will remain displayed while the others get hidden

Categories

(Toolkit :: Picture-in-Picture, defect)

Toolkit ▾
Picture-in-Picture ▾

Desktop

Tracking

(bug has been fixed and VERIFIED)

VERIFIED FIXED

114 Branch

Tracking Status
firefox-esr102 --- wontfix
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- wontfix
firefox114 --- verified

People

(Reporter: peter.magyari, Assigned: bnasar)

References

Details

(Whiteboard: [fidefe-pip3])

Note

  • The behaviour should be consistent with the original player's behaviour (none of the video control buttons get hidden when one of them is being hovered on)

Found in

  • Nightly 112.0a1

Affected versions

  • Nightly 1112.0a1
  • Firefox 110.0
  • ESR v102.8.0esr

Tested platforms

  • Affected platforms: All

Steps to reproduce

  1. Play a video on youtube and launch PiP
  2. Go into fullscreen by double clicking the PiP window or use the fullscreen button.
  3. Hover over any button and wait 3s seconds.

Expected result

  • When hovering over a button, none of the video controls should get hidden.

Actual result

  • Only the hovered-on button stays visible, and other controls get hidden after 3s.

Regression range

  • Not a recent regression.
Assignee: nobody → bnasar
Status: NEW → ASSIGNED
Whiteboard: [fidefe-pip3]
Summary: In fullscreen PiP only the hovered-on video control button remains visible → In fullscreen PiP only the hovered-on Seek forward/backward buttons remains visible
Summary: In fullscreen PiP only the hovered-on Seek forward/backward buttons remains visible → When hovering a PiP button while fullscreen, it will remain displayed while the others get hidden
Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/42dfc5b63e8b
Refactor revealControls() to prevent hiding other controls when hovering over a video control button. r=kpatenio,pip-reviewers
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

The patch landed in nightly and beta is affected.
:bnasar, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(bnasar)
Flags: needinfo?(kpatenio)
Flags: needinfo?(bnasar)

I have verified the fix using Nightly 114.0a1 (20230501093846) on Windows 7/10 and MacOS 11.6.
The video controls no longer get hidden while hovering over a button in fullscreen.

You need to log in before you can comment on or make changes to this bug.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK