[arithmetic_side_effects] Cache symbols by c410-f3r · Pull Request #10675 · rust...
source link: https://github.com/rust-lang/rust-clippy/pull/10675
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
[arithmetic_side_effects] Cache symbols #10675
Conversation
An internal-only modification to speed up the processing of symbols because "intern" isn't very cheap, even more when you are doing the same thing for every method expression.
changelog: none
Collaborator
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Contributor
|
Good catch! @bors r+ |
Commit 
Testing commit Contributor
|
|
Test failed - Contributor
|
Ah, we missed the changelog line. @bors retry |
Contributor
|
Isn't it simpler to add that strings to symbol table, and then just filter on symbols, skipping str<->String comparison/conversions? |
Contributor
Author
|
That is what I asked at #10615 (comment) IIRC, it is not rare to see PRs in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK