fix lint regression in `non_upper_case_globals` by Ezrashaw · Pull Request #1105...
source link: https://github.com/rust-lang/rust/pull/110575
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Fixes #110573
The issue also exists for inherent associated types (where I copied my impl from). EarlyContext is more involved to fix in this way, so I'll leave it be for now (note it's unstable so that's not urgent).
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Hm.. I think this is a bit too complicated for what it's worth.
Can you just revert your original PR, and just check the associate const's container similarly to how method_context does to make sure that the NonSnakeCase lint only fires on inherent methods?
changed the title
fix: Cellify "last node" field on LateContext
fix lint regression in non_upper_case_globals
Contributor
Author
|
@compiler-errors I reverted and re-implemented. I haven't fixed it for inherent associated types, would you like that in this PR or a followup? (note that it's an early lint so we'd need to convert it to |
please squash this into one commit, and preferably (but I guess not required) fix the NonCamelCaseTypes lint for associated types too?
Outdated Show resolved
Contributor
Author
|
@compiler-errors I've implemented your review comments. The inherent associated types part is too complex to do right now, unrelated parts of the lint stop working when I tried to make it a late lint. It is and unstable feature so we might just leave it as is for now? Also, sorry that this is taking so long; I only have access to my laptop right now. |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Regression in non_upper_case_globals lint level attribute on associated item
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK