4

Panic instead of truncating if the incremental on-disk cache is too big by saeth...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/110632
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Panic instead of truncating if the incremental on-disk cache is too big #110632

Conversation

Contributor

It seems unlikely that anyone would hit this truncation, but if this as does actually truncate, that seems incredibly bad.

Collaborator

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Apr 21, 2023

Contributor

@bors r+ rollup

Contributor

pushpin Commit 010deb5 has been approved by lcnr

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Apr 21, 2023

cjgillot

changed the title Panic instead of truncating if the dep graph is too big

Panic instead of truncating if the incremental on-disk cache is too big

Apr 21, 2023

bors

merged commit 1d1453a into

rust-lang:master

Apr 21, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

lcnr

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK