6

fix: remove extra argument "rustc" by whentojump · Pull Request #14647...

 1 year ago
source link: https://github.com/rust-lang/rust-analyzer/pull/14647
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

fix: remove extra argument "rustc" #14647

Conversation

Contributor

Two extra "rustc"s were accidentally introduced here. (I guess because cmd is sometimes initialized with a cargo under the hood, sometimes rustc, thus error-prone?)

One of them has been fixed here. This patch fixes the other.

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Apr 24, 2023

Member

Thanks for catching that!
@bors r+
whentojump reacted with heart emoji

Collaborator

pushpin Commit 59c4cc3 has been approved by Veykril

It is now in the queue for this repository.

Collaborator

hourglass Testing commit 59c4cc3 with merge 0c0025f...

Collaborator

sunny Test successful - checks-actions
Approved by: Veykril
Pushing 0c0025f to master...
1 similar comment

Collaborator

eyes Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

bors

merged commit 0c0025f into

rust-lang:master

Apr 24, 2023

9 of 10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Veykril

Veykril approved these changes
Assignees

No one assigned

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK