4

spec: guarantee non-nil return value from recover · Issue #25448 · golang/go · G...

 1 year ago
source link: https://github.com/golang/go/issues/25448
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Contributor

rsc commented Nov 21, 2022

Looking through my 2020 Go corpus more, after I remove all the forks of go-ethereum (which use panic(nil) as panic("impossible")) and forks of the go repo itself and any hits in _test.go files, I am left with these:

android.googlesource.com/platform/build/[email protected]/cmd/fileslist/fileslist.go:169:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:77:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:176:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:236:					panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:289:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:352:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:359:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:366:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:378:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:388:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:399:		panic(nil)
bitbucket.org/anacrolix/[email protected]/builtins.go:434:		panic(nil)
bitbucket.org/anacrolix/[email protected]/parse.go:56:	panic(nil)
bitbucket.org/orus-io/[email protected]/services/control/envelope.go:24:			panic(nil)
bitbucket.org/orus-io/[email protected]/services/control/envelope.go:24:			panic(nil)
github.com/AWildBeard/[email protected]/linux/hci/hci.go:842:	panic(nil)
github.com/Bearnie-H/[email protected]/server/router.go:29:		panic(nil)
github.com/Centny/[email protected]/im/mdb.go:96:		panic(nil)
github.com/DSiSc/[email protected]/scripts/bench.go:239:		panic(nil)
github.com/DataReply/[email protected]/templateutil/templateutil.go:220:		panic(nil)
github.com/DataReply/[email protected]/templateutil/templateutil.go:225:		panic(nil)
github.com/Fanatics/[email protected]/operators.go:465:	panic(nil)
github.com/JamesnaW/[email protected]/log.go:52:	panic(nil)
github.com/MixinNetwork/[email protected]/model/transactions/mosaicdefinitiondransaction.go:75:		panic(nil)
github.com/MixinNetwork/[email protected]/model/transactions/mosaicdefinitiondransaction.go:81:				panic(nil)
github.com/MixinNetwork/[email protected]/model/transactions/namespacetrovisiontransaction.go:62:				panic(nil)
github.com/MixinNetwork/[email protected]/model/transactions/transfertransaction.go:118:				panic(nil)
github.com/NVIDIA/[email protected]/bench/soaktest/soakprim/conditions.go:31:			panic(nil)
github.com/NVIDIA/[email protected]/bench/soaktest/soakprim/conditions.go:89:			panic(nil)
github.com/NVIDIA/[email protected]/bench/soaktest/soakprim/conditions.go:31:			panic(nil)
github.com/NVIDIA/[email protected]/bench/soaktest/soakprim/conditions.go:89:			panic(nil)
github.com/Soontao/[email protected]/solution_list.go:30:		panic(nil)
github.com/Soontao/[email protected]/solutions.go:65:		panic(nil)
github.com/Soontao/[email protected]/source_version.go:61:		panic(nil)
github.com/Soontao/[email protected]/sources.go:57:		panic(nil)
github.com/Soontao/[email protected]/solution_list.go:30:		panic(nil)
github.com/Soontao/[email protected]/solutions.go:65:		panic(nil)
github.com/Soontao/[email protected]/source_version.go:61:		panic(nil)
github.com/Soontao/[email protected]/sources.go:57:		panic(nil)
github.com/YongInSamsung/[email protected]/operators.go:464:	panic(nil)
github.com/YoshikiShibata/[email protected]/ch04/ex12/xkcd.go:224:		panic(nil)
github.com/YoshikiShibata/[email protected]/ch04/ex12/xkcd.go:229:		panic(nil)
github.com/admpub/[email protected]/library/telnet/telnet.go:481:	panic(nil)
github.com/alanwu4321/[email protected]/bot/util.go:50:		panic(nil)
github.com/alexjialene/redis-info/[email protected]/util.go:94:		panic(nil)
github.com/bencicandrej/[email protected]/swarm/storage/memstore.go:260:				panic(nil)
github.com/bencicandrej/[email protected]/swarm/storage/memstore.go:278:			panic(nil)
github.com/better0332/[email protected]/proxy/utility.go:546:			panic(nil)
github.com/biased-unit/[email protected]/operators.go:464:	panic(nil)
github.com/blampe/[email protected]/src/svg.go:58:		panic(nil)
github.com/chzyer/[email protected]/test.go:59:	panic(nil)
github.com/chzyer/[email protected]/test.go:59:	panic(nil)
github.com/containership/[email protected]/cmd/ssh.go:114:		panic(nil)
github.com/coschain/[email protected]/app/table/tools/main.go:168:			panic(nil)
github.com/coschain/[email protected]/app/table/tools/main.go:168:			panic(nil)
github.com/cozely/[email protected]/examples/snake/main.go:244:			panic(nil)
github.com/cozely/[email protected]/examples/snake/main.go:253:	panic(nil)
github.com/cznic/[email protected]/nquads/etc.go:77:		panic(nil)
github.com/cznic/[email protected]/nquads/etc.go:77:		panic(nil)
github.com/davecheney/[email protected]/juju/src/github.com/juju/juju/worker/uniter/hook/hooktesting/source.go:84:		panic(nil)
github.com/davecheney/[email protected]/juju/src/github.com/juju/juju/worker/uniter/hook/hooktesting/source.go:91:		panic(nil)
github.com/davidwalter0/[email protected]/cmd/cookie/client/client.go:45:		panic(nil)
github.com/dev-means/[email protected]/context.go:77:		panic(nil)
github.com/dev-means/[email protected]/context.go:117:			panic(nil)
github.com/dev-means/[email protected]/context.go:135:		panic(nil)
github.com/dev-means/[email protected]/context.go:139:			panic(nil)
github.com/discoverkl/[email protected]/ui/vue.go:186:	panic(nil)
github.com/drakmaniso/[email protected]/examples/snake/main.go:244:			panic(nil)
github.com/drakmaniso/[email protected]/examples/snake/main.go:253:	panic(nil)
github.com/eaigner/[email protected]/cmd/cmd.go:226:		panic(nil)
github.com/feyeleanor/[email protected]/vm/processor_core.go:164:		panic(nil)
github.com/feyeleanor/[email protected]/runtime.go:4:	panic(nil)
github.com/feyeleanor/[email protected]/runtime.go:4:	panic(nil)
github.com/finnomena/[email protected]/log.go:52:	panic(nil)
github.com/flanksource/[email protected]/cmd/common.go:65:		panic(nil)
github.com/flanksource/[email protected]/cmd/common.go:65:		panic(nil)
github.com/ftrvxmtrx/[email protected]/player/player.go:300:				panic(nil)
github.com/ftrvxmtrx/[email protected]/vfs/entry.go:44:	panic(nil)
github.com/ftrvxmtrx/[email protected]/vfs/entry.go:88:	panic(nil)
github.com/ftrvxmtrx/[email protected]/player/player.go:300:				panic(nil)
github.com/ftrvxmtrx/[email protected]/vfs/entry.go:44:	panic(nil)
github.com/ftrvxmtrx/[email protected]/vfs/entry.go:88:	panic(nil)
github.com/gcla/[email protected]/streams/parse.go:63:		panic(nil)
github.com/gcla/[email protected]/streams/parse.go:63:		panic(nil)
github.com/gcla/termshark/[email protected]/streams/parse.go:63:		panic(nil)
github.com/geode-lang/[email protected]/pkg/ast/AST.go:106:		panic(nil)
github.com/go-interpreter/[email protected]/interp/testdata/recover.go:11:	panic(nil)
github.com/go-lintpack/[email protected]/checkers/testdata/panicNil/positive_tests.go:6:		panic(nil)
github.com/hedzr/[email protected]/xs/xs_echo_logger.go:177:	panic(nil)
github.com/herb-go/[email protected]/middleware/csrf/csrf.go:50:		panic(nil)
github.com/herb-go/[email protected]/middleware/csrf/csrf.go:65:		panic(nil)
github.com/herb-go/[email protected]/middleware/csrf/csrf.go:50:		panic(nil)
github.com/herb-go/[email protected]/middleware/csrf/csrf.go:65:		panic(nil)
github.com/hksk8s/[email protected]/cmd/ssh.go:114:		panic(nil)
github.com/hsfish/[email protected]/conn.go:382:	panic(nil)
github.com/huacnlee/[email protected]/app/controllers/app.go:32:	panic(nil)
github.com/i-am-david-fernandez/[email protected]/internal/restic.go:32:		panic(nil)
github.com/inCaller/[email protected]/main.go:265:		panic(nil)
github.com/inCaller/[email protected]/main.go:270:		panic(nil)
github.com/isarq/[email protected]/model/transactions/mosaicdefinitiondransaction.go:74:		panic(nil)
github.com/isarq/[email protected]/model/transactions/mosaicdefinitiondransaction.go:80:				panic(nil)
github.com/isarq/[email protected]/model/transactions/namespacetrovisiontransaction.go:57:				panic(nil)
github.com/isarq/[email protected]/model/transactions/transfertransaction.go:63:				panic(nil)
github.com/isarq/[email protected]/model/transactions/transfertransaction.go:115:				panic(nil)
github.com/jamesnaw/[email protected]/log.go:39:	panic(nil)
github.com/kitech/[email protected]/zend/utils.go:26:		panic(nil)
github.com/kitech/[email protected]/zend/utils.go:36:		panic(nil)
github.com/kokizzu/[email protected]/cmd/cmd.go:226:		panic(nil)
github.com/kubernetes/[email protected]/pkg/composite/meta/meta.go:277:		panic(nil)
github.com/kubevirt/[email protected]/tools/csv-generator/csv-generator.go:72:		panic(nil)
github.com/kubevirt/[email protected]/tools/csv-generator/csv-generator.go:72:		panic(nil)
github.com/l-vitaly/[email protected]/zend/utils.go:26:		panic(nil)
github.com/l-vitaly/[email protected]/zend/utils.go:36:		panic(nil)
github.com/liumingmin/[email protected]/main.go:61:		panic(nil)
github.com/liumingmin/[email protected]/main.go:59:		panic(nil)
github.com/lovego/[email protected]/stack.go:14:	panic(nil)
github.com/masahiro331/[email protected]/ch05/ex19/main.go:14:	panic(nil)
github.com/mhilton/[email protected]/worker/uniter/hook/hooktesting/source.go:84:		panic(nil)
github.com/mhilton/[email protected]/worker/uniter/hook/hooktesting/source.go:91:		panic(nil)
github.com/moshloop/[email protected]/cmd/common.go:65:		panic(nil)
github.com/mzpqnxow/[email protected]/conn.go:382:	panic(nil)
github.com/netrixone/[email protected]/log.go:29:	panic(nil)
github.com/netrixone/[email protected]/log.go:29:	panic(nil)
github.com/nickwanninger/[email protected]/pkg/ast/AST.go:106:		panic(nil)
github.com/nilzeronull/[email protected]/player/player.go:300:				panic(nil)
github.com/nilzeronull/[email protected]/vfs/entry.go:44:	panic(nil)
github.com/nilzeronull/[email protected]/vfs/entry.go:88:	panic(nil)
github.com/omc/[email protected]/parser.go:153:				panic(nil)
github.com/onemorecloud/[email protected]/parser.go:153:				panic(nil)
github.com/ouxuanserver/[email protected]/src/core/response.go:24:		panic(nil)
github.com/ouxuanserver/[email protected]/src/core/response.go:30:	panic(nil)
github.com/packethost/[email protected]/main.go:56:		panic(nil)
github.com/pechorin/[email protected]/pkg/measureconv/measureconv.go:223:		panic(nil)
github.com/pechorin/[email protected]/pkg/measureconv/measureconv.go:228:		panic(nil)
github.com/pkliczewski/[email protected]/tools/cdi-olm-catalog/main.go:191:			panic(nil)
github.com/pkliczewski/[email protected]/tools/cdi-olm-catalog/main.go:197:			panic(nil)
github.com/pkliczewski/[email protected]/tools/cdi-olm-catalog/main.go:211:			panic(nil)
github.com/pkliczewski/[email protected]/tools/cdi-olm-catalog/main.go:216:			panic(nil)
github.com/platinummonkey/[email protected]/examples/grpc_streaming/main.go:108:		panic(nil)
github.com/platinummonkey/[email protected]/examples/grpc_unary/main.go:89:		panic(nil)
github.com/platinummonkey/[email protected]/examples/grpc_streaming/main.go:108:		panic(nil)
github.com/platinummonkey/[email protected]/examples/grpc_unary/main.go:89:		panic(nil)
github.com/pseudomind/[email protected]/raw/runtime.go:10:	panic(nil)
github.com/rigado/[email protected]/linux/hci/hci.go:834:	panic(nil)
github.com/rigado/[email protected]/linux/hci/hci.go:842:	panic(nil)
github.com/runner-mei/[email protected]/telnet.go:482:	panic(nil)
github.com/shabbyrobe/[email protected]/typequeue.go:40:		panic(nil)
github.com/shabbyrobe/[email protected]/typequeue.go:40:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:157:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:190:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:231:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:110:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:143:		panic(nil)
github.com/shabbyrobe/[email protected]/node.go:184:		panic(nil)
github.com/snowdreams1006/[email protected]/error/web.go:82:		panic(nil)
github.com/spx/[email protected]/cmd/cmd.go:226:		panic(nil)
github.com/stackpath/[email protected]/tools/csv-generator/csv-generator.go:72:		panic(nil)
github.com/thesunnysky/[email protected]/client/config.go:43:		panic(nil)
github.com/tommie/[email protected]/transfer/transfer.go:85:		panic(nil)
github.com/tonytins/fmote/[email protected]/config.go:24:		panic(nil)
github.com/toy80/[email protected]/vorbis/decode.go:345:				panic(nil)
github.com/toy80/[email protected]/audio/vorbis/decode.go:345:				panic(nil)
github.com/uk0/[email protected]/lib/glman/dyndraw.go:108:	panic(nil)
github.com/vchimishuk/[email protected]/player/player.go:300:				panic(nil)
github.com/vchimishuk/[email protected]/vfs/entry.go:44:	panic(nil)
github.com/vchimishuk/[email protected]/vfs/entry.go:88:	panic(nil)
github.com/vlorc/[email protected]/text/text.go:33:		panic(nil)
github.com/vlorc/[email protected]/text/token.go:102:			panic(nil)
github.com/vlorc/[email protected]/text/text.go:33:		panic(nil)
github.com/vlorc/[email protected]/text/token.go:102:			panic(nil)
github.com/wailovet/[email protected]/src/core/response.go:25:		panic(nil)
github.com/wailovet/[email protected]/src/core/response.go:40:	panic(nil)
github.com/wangbjun/[email protected]/GoSort/cmd/pipelineDemo/main.go:16:		panic(nil)
github.com/wangbjun/[email protected]/GoSort/cmd/pipelineDemo/main.go:28:		panic(nil)
github.com/wangbjun/[email protected]/GoSort/pipeline/netNode.go:11:		panic(nil)
github.com/wangbjun/[email protected]/GoSort/pipeline/netNode.go:17:			panic(nil)
github.com/wangbjun/[email protected]/GoSort/pipeline/netNode.go:33:			panic(nil)
github.com/whjstc/[email protected]/app/service/main/tv/internal/service/service.go:131:		panic(nil)
github.com/wreulicke/[email protected]/examples/grpc_streaming/main.go:108:		panic(nil)
github.com/wreulicke/[email protected]/examples/grpc_unary/main.go:89:		panic(nil)
github.com/wumingshi0531/[email protected]/openbilibili-go-common-master/openbilibili-go-common-master/app/service/main/tv/internal/service/service.go:131:		panic(nil)
github.com/xxxtai/[email protected]/app/service/main/tv/internal/service/service.go:131:		panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/packet.go:55:		panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/packet.go:84:		panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/protocol.go:38:	panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/protocol.go:75:	panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/packet.go:56:		panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/packet.go:85:		panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/protocol.go:38:	panic(nil)
github.com/yuuki0xff/[email protected]/tracer/protocol/protocol.go:75:	panic(nil)
github.com/zJean001/[email protected]/app/service/main/tv/internal/service/service.go:131:		panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:136:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:154:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:172:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:190:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:225:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:269:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:312:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:340:	panic(nil)
github.com/ziutek/[email protected]/autorc/autorecon.go:368:	panic(nil)
github.com/ziutek/[email protected]/conn.go:381:	panic(nil)
github.com/ziutek/[email protected]/conn.go:382:	panic(nil)
github.com/zrepl/[email protected]/platformtest/platformtest.go:23:	panic(nil)
k8s.io/[email protected]/pkg/composite/meta/meta.go:210:		panic(nil)
k8s.io/[email protected]/pkg/composite/meta/meta.go:277:		panic(nil)
kubevirt.io/[email protected]/tools/csv-generator/csv-generator.go:72:		panic(nil)
kubevirt.io/[email protected]/tools/csv-generator/csv-generator.go:72:		panic(nil)
modernc.org/[email protected]/nquads/etc.go:77:		panic(nil)
v.io/x/[email protected]/gosh/shell.go:242:	panic(nil)
v.io/x/[email protected]/gosh/shell.go:242:	panic(nil)
xbus.io/[email protected]/services/control/envelope.go:24:			panic(nil)
xbus.io/[email protected]/services/control/envelope.go:24:			panic(nil)
xbus.io/[email protected]/services/control/envelope.go:24:			panic(nil)

I have not looked at all of these. If anyone is interested, please feel free. I will post about a few of them in the next comment.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK