2

Always evaluate vecs of subdiagnostics eagerly by mejrs · Pull Request #105233 ·...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/105233
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Always evaluate vecs of subdiagnostics eagerly #105233

Conversation

Collaborator

rustbot commented Dec 4, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

rustbot

added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 4, 2022

Collaborator

rustbot commented Dec 4, 2022

Contributor

estebank commented Dec 12, 2022

@bors r+

Contributor

bors commented Dec 12, 2022

pushpin Commit a7838d8 has been approved by estebank

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Dec 12, 2022

Contributor

bors commented Dec 14, 2022

hourglass Testing commit a7838d8 with merge fbf8b93...

Contributor

bors commented Dec 14, 2022

sunny Test successful - checks-actions
Approved by: estebank
Pushing fbf8b93 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Dec 14, 2022

bors

merged commit fbf8b93 into

rust-lang:master

Dec 14, 2022

11 checks passed

Collaborator

rust-timer commented Dec 14, 2022

Finished benchmarking commit (fbf8b93): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

estebank

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK