Check AArch64 branch-protection earlier in the pipeline. by jacobbramley · Pull...
source link: https://github.com/rust-lang/rust/pull/105421
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
jacobbramley
commented
Dec 7, 2022
added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Member
nagisa
left a comment
Really nice. One nit inline, but otherwise r=me.
if sess.target.arch == "aarch64" { |
||
if let Some(BranchProtection { bti, pac_ret }) = sess.opts.unstable_opts.branch_protection { |
Rather than making this a no-op, we should probably bug! this, so that any issues with checking in rustc_session don’t get silently ignored.
Contributor
Author
jacobbramley
Dec 14, 2022
Good point! Done in 73d374f.
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Member
nagisa commented Dec 14, 2022
|
@bors r+ |
Contributor
bors commented Dec 14, 2022
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
bors commented Dec 16, 2022
Testing commit Contributor
bors commented Dec 16, 2022
|
|
Test failed - added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
Author
jacobbramley commented Dec 16, 2022
The test fails on an off-by-one error on some documentation layout. It doesn't appear at all relevant to this PR. Note, however, that I can reproduce the error reliably on my branch, but only when run as part of the full sequence. For example, I can't reproduce it by isolating the failing test as follows: Note that dropping Attempting to work out what the failure actually was:
Manually rendering the test file in Firefox shows a At this point, I am somewhat at a loss. @willcrichton, it seems that you did some work on this test recently. Have you any ideas? |
Collaborator
rust-log-analyzer commented Dec 16, 2022
Contributor
tmiasko commented Dec 16, 2022
|
@bors retry unrelated rustdoc-gui failure |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
willcrichton commented Dec 16, 2022
|
I will check why this test is flaky. cc @GuillaumeGomez have you seen any issues like this w/ browser-UI-test before? |
Contributor
bors commented Dec 17, 2022
Contributor
bors commented Dec 17, 2022
|
|
removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Contributor
willcrichton commented Dec 17, 2022
|
Oh no, a different GUI test failed... @GuillaumeGomez this looks like a broader flakiness problem. |
|
For the GUI failure, linked to #93784. |
|
Since it's not related to this PR, let's retry. @bors retry |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
bors commented Dec 17, 2022
Contributor
bors commented Dec 17, 2022
|
|
Test successful - Collaborator
rust-timer commented Dec 17, 2022
|
Finished benchmarking commit (aef17b7): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
- | - | 0 |
Improvements  (primary) |
-0.4% | [-0.4%, -0.4%] | 1 |
| Improvements (secondary) |
-0.4% | [-0.4%, -0.4%] | 1 |
| All (primary) |
-0.4% | [-0.4%, -0.4%] | 1 |
Max RSS (memory usage)
Results
Cycles
This benchmark run did not return any relevant results for this metric.
Collaborator
rust-log-analyzer commented Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK