Port site specific search from pine to central
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1794823
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
The maintenance window should be no more than two hours. Thanks!
Port site specific search from pine to central
Categories
(Firefox :: Address Bar, enhancement)
Tracking
(bug RESOLVED as FIXED)
109 Branch
Tracking | Status | |
---|---|---|
firefox109 | --- | fixed |
People
(Reporter: hjones, Assigned: hjones)
References
(Regressed 1 open bug)
Details
As part of the pine work the Service Integrations team built out a contextual search/site specific search Urlbar result that allows the user to quickly execute a search via the search engine from the active page, provided the site utilizes OpenSearch.
The code for this feature contains nothing pine specific, so this seems like a good candidate for a feature we could easily port over to central.
This bug covers the initial work involved in getting the basic feature working on central behind a pref. From there, we can get more feedback from engineers/product managers with more urlbar domain knowledge and decide on next steps.
Some random thoughts:
- This is a minimal implementation - there were plans to expand this with autocomplete support that we never got around to
- I built this just from reading docs + poking around in the urlbar code, so there might be a more desireable way to do all of this
- We've gone back and forth between calling this "contextual search" and "site specific search," we should probably pick a name and stick to it
- There were never any design specs for this so the UI/UX was based off of existing urlbar results as they appeared in Flowstate
- There were some open questions around how we treat installing opensearch engines, since how they are handled here seems to differ from how we use them elsewhere
- I don't remember the reasoning for showing this result last in the urlbar, we may want to move it elsewhere
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK