Make `char::is_lowercase` and `char::is_uppercase` const by mx00s · Pull Request...
source link: https://github.com/rust-lang/rust/pull/101401
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Make char::is_lowercase
and char::is_uppercase
const
#101401
Conversation
added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label
Collaborator
rust-highfive commented 5 days ago
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Member
fee1-dead left a comment
LGTM other than to make the types of constants &'static [T; N]
instead of arrays to prevent copying.
Collaborator
rustbot commented 4 days ago
added the const-hack This PR introduced a hack to make things valid in `const fn`. label
Collaborator
rustbot commented 4 days ago
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Contributor
Author
mx00s commented 4 days ago
@rustbot label +T-libs-api -T-libs |
added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
and removed T-libs Relevant to the library team, which will review and decide on the PR/issue.
labels
Contributor
Author
mx00s commented 4 days ago
Thank you for the helpful feedback and positive review, @fee1-dead. I'm a new contributor, so I have a procedural question. Now that I've made the requested changes will you (or someone else) also have to tell bors |
Looks good to me, thanks for the PR. An @bors r+ |
Contributor
bors commented 4 days ago
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK