6

Make `char::is_lowercase` and `char::is_uppercase` const by mx00s · Pull Request...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/101401
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Make char::is_lowercase and char::is_uppercase const #101401

Conversation

Contributor

@mx00s mx00s commented 5 days ago

Implements #101400.

All reactions

rustbot

added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label

5 days ago

Collaborator

rust-highfive commented 5 days ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

rust-highfive

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

5 days ago

Member

@fee1-dead fee1-dead left a comment

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

All reactions

Collaborator

rustbot commented 4 days ago

Error: Label const-hack can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

fee1-dead

added the const-hack This PR introduced a hack to make things valid in `const fn`. label

4 days ago

Collaborator

rustbot commented 4 days ago

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Contributor

Author

mx00s commented 4 days ago

@rustbot label +T-libs-api -T-libs

rustbot

added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

and removed T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

4 days ago

Contributor

Author

mx00s commented 4 days ago

LGTM other than to make the types of constants &'static [T; N] instead of arrays to prevent copying.

Thank you for the helpful feedback and positive review, @fee1-dead.

I'm a new contributor, so I have a procedural question. Now that I've made the requested changes will you (or someone else) also have to tell bors r+ or will your GitHub approval be sufficient?

Member

fee1-dead commented 4 days ago

edited

Looks good to me, thanks for the PR. An r+ is needed to merge. The GitHub approval is not used for this purpose.

@bors r+

mx00s reacted with heart emoji All reactions

Contributor

bors commented 4 days ago

pushpin Commit 2b328ea has been approved by fee1-dead

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

4 days ago

bors

merged commit d9bba11 into

rust-lang:master

4 days ago

10 checks passed

rustbot

added this to the 1.65.0 milestone

4 days ago

rust-timer

added a commit to rust-lang-ci/rust that referenced this issue

4 days ago

mx00s

deleted the expand-const branch

4 days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels
const-hack This PR introduced a hack to make things valid in `const fn`. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

None yet

8 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK