more clippy::perf fixes by matthiaskrgr · Pull Request #101391 · rust-lang/rust...
source link: https://github.com/rust-lang/rust/pull/101391
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
more clippy::perf fixes #101391
Conversation
Collaborator
rust-highfive commented 5 days ago
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
.collect::<Vec<_>>(); |
||
for (def_id, encode_const, encode_opt) in keys_and_jobs.into_iter() { |
||
let keys_and_jobs = tcx.mir_keys(()).iter().filter_map(|&def_id| { |
||
let (encode_const, encode_opt) = should_encode_mir(tcx, def_id); |
||
if encode_const || encode_opt { Some((def_id, encode_const, encode_opt)) } else { None } |
||
}); |
||
for (def_id, encode_const, encode_opt) in keys_and_jobs { |
this one gets rid of that collecton line 1392, rest is reformatting
Contributor
oli-obk commented 4 days ago
|
@bors r+ |
Contributor
bors commented 4 days ago
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK