Forbid mixing `System` with direct sytem allocator calls by CAD97 · Pull Request...
source link: https://github.com/rust-lang/rust/pull/101394
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Forbid mixing System with direct sytem allocator calls
#101394
Merged
Conversation
Contributor
CAD97
commented
5 days ago
e.g. on windows, trying to mix System::alloc and HeapFree will not work because of the extra work done to serve higher alignments.
added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label
Collaborator
rust-highfive commented 5 days ago
|
(rust-highfive has picked a reviewer for you, use r? to override) |
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. I-libs-api-nominated Indicates that an issue has been nominated for discussion during a libs-api team meeting. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete.
labels
|
@bors r+ rollup I'll nominate in case libs-api has other opinions, but I think this basically just documents the current state and one that isn't really plausible to change (more restrictive on users rather than more permissive, too), so I don't think a dedicated FCP is necessary here. |
Contributor
bors commented 4 days ago
Commit Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK