Do not unconditionally succeed RUSTC_WRAPPER checks when run by build scripts by...
source link: https://github.com/rust-lang/rust-analyzer/pull/13010
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
Veykril commented 7 days ago
rust-analyzer's RUSTC_WRAPPER unconditionally succeeds cargo check
invocations tripping up build scripts using cargo check
to probe for
successful compilations. To prevent this from happening the RUSTC_WRAPPER
now checks if it's run from a build script by looking for theCARGO_CFG_TARGET_ARCH
env var that cargo sets only when running build
scripts.
Contributor
eminence commented 7 days ago
I tested this on two workspaces that exhibit the problem reported with |
Thank you for testing! There shouldn't be any regressions caused due to this (unless cargo sets this env var in other occasions which it shouldn't) |
Collaborator
bors commented 7 days ago
Collaborator
bors commented 7 days ago
Collaborator
bors commented 6 days ago
Test successful - checks-actions |
sdroege commented 3 days ago
This seems to cause unnecessary rebuilds, it seems. Some crate that depends on |
Member
Author
Veykril commented 3 days ago
this is only invoked on startup for rust-analyzer, so this cannot have changed the behavior for when you save |
sdroege commented 3 days ago
Hrm, then something else must've changed between this and last Monday's release. Sorry for the noise here then. |
Member
Author
Veykril commented 3 days ago
The only recent relevant change I could think of is #12808, but that is 2 releases ago, not one |
You might be hitting this issue. |
sdroege commented 3 days ago
Thanks, that seems to have fixed this |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK