4

asm: Allow the use of r8-r14 as clobbers on Thumb1 by Amanieu · Pull Request #93...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/93877
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

@@ -298,54 +299,87 @@ impl InlineAsmReg {

arch: InlineAsmArch,

target_features: &FxHashSet<Symbol>,

target: &Target,

is_clobber: bool,

Copy link

Member

@nagisa nagisa 8 days ago

edited

I wonder if it wouldn't make sense to proactively make this a tri-state enum describing the context (clobber, input, output). I can imagine it being useful when we decide to actually start adding constraint classes that are applicable to input or output only.

And today it would serve as a way to avoid bool proliferation.

Copy link

Contributor

Author

@Amanieu Amanieu 7 days ago

I have a followup PR based on this one which is a pain to rebase. I'll make the change there.


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK