lib, device: begin using list::List instead of custom structs by woodruffw · Pul...
source link: https://github.com/Smithay/udev-rs/pull/22
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
See #21.
N.B.: This doesn't modify the enumerator::Devices
implementation, since that uses a custom Iterator<Item=Device>
rather than Item=list::Entry
.
Gentle ping on this
I am wondering, if we could make type aliases for Property
and Attribute
to list::Entry
for backwards compatibility.
But it seems with #23 I need to yank 0.5.1 anyway and it this point we could just do 0.6.0 with hwdb
and full usage of list
.
N.B.: This doesn't modify the
enumerator::Devices
implementation, since that uses a customIterator<Item=Device>
rather thanItem=list::Entry
.
Could we not make List
generic over the Entry
-type and make Entry
the default? (List<E=Entry<'_>>
)
Then we could re-use List
for enumerator::Devices
as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK