8

lib, device: begin using list::List instead of custom structs by woodruffw · Pul...

 2 years ago
source link: https://github.com/Smithay/udev-rs/pull/22
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Copy link

Contributor

woodruffw commented on Jan 5, 2021

edited

See #21.

woodruffw

marked this pull request as ready for review

12 months ago

Copy link

Contributor

Author

woodruffw commented on Jan 6, 2021

N.B.: This doesn't modify the enumerator::Devices implementation, since that uses a custom Iterator<Item=Device> rather than Item=list::Entry.

Copy link

Contributor

Author

woodruffw commented on Jan 15, 2021

Gentle ping on this slightly_smiling_face

Copy link

Member

Drakulix commented on Jan 15, 2021

I am wondering, if we could make type aliases for Property and Attribute to list::Entry for backwards compatibility.

But it seems with #23 I need to yank 0.5.1 anyway and it this point we could just do 0.6.0 with hwdb and full usage of list.

N.B.: This doesn't modify the enumerator::Devices implementation, since that uses a custom Iterator<Item=Device> rather than Item=list::Entry.

Could we not make List generic over the Entry-type and make Entry the default? (List<E=Entry<'_>>)
Then we could re-use List for enumerator::Devices as well.

Drakulix

merged commit 7fc5247 into

Smithay:master on Jan 25, 2021

1 check passed

woodruffw

deleted the ww/use-list branch

18 days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
None yet
Projects

None yet

Milestone

No milestone

Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK