6

node-template: remove redundant types from runtime by disconnect3d · Pull Reques...

 2 years ago
source link: https://github.com/paritytech/substrate/pull/9161
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Contributor

Author

disconnect3d commented on Jun 21, 2021 •

edited

To add on this, this was flagged by the https://github.com/est31/warnalyzer tool, along with some other stuff:

node/src/cli.rs:16:6: unused Field '0'
node/src/cli.rs:18:12: unused Field '0'
node/src/cli.rs:21:13: unused Field '0'
node/src/cli.rs:24:15: unused Field '0'
node/src/cli.rs:27:14: unused Field '0'
node/src/cli.rs:30:15: unused Field '0'
node/src/cli.rs:33:13: unused Field '0'
node/src/cli.rs:36:9: unused Field '0'
node/src/cli.rs:40:12: unused Field '0'
node/src/main.rs:1:1: unused Mod ''
node/src/main.rs:11:4: unused Function 'main'
pallets/template/src/lib.rs:32:20: unused Type 'T'
pallets/template/src/lib.rs:40:21: unused Type 'T'
pallets/template/src/lib.rs:50:19: unused Field '0'
pallets/template/src/lib.rs:50:24: unused Field '1'
pallets/template/src/lib.rs:55:17: unused Type 'T'
pallets/template/src/lib.rs:73:56: unused Field '0'
runtime/src/lib.rs:57:10: unused Type 'AccountIndex'
runtime/src/lib.rs:69:10: unused Type 'DigestItem'
runtime/src/lib.rs:85:11: unused Type 'BlockId'
runtime/src/lib.rs:127:11: unused Const 'DAYS'
runtime/src/lib.rs:304:10: unused Type 'SignedBlock'
runtime/src/lib.rs:306:10: unused Type 'BlockId'
runtime/src/lib.rs:320:10: unused Type 'CheckedExtrinsic'

The AccountIndex and DigestItem are already proposed to be removed in #9149 and the AccountIndex removal was also merged to the substrate-node-template repo in substrate-developer-hub/substrate-node-template#204.

Note that I am not removing the DAYS here as I believe it may be useful for devs to have it around and not calculate by themself?


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK