1

Update the Linux install steps and package listing by mike-myers-tob · Pull Requ...

 2 years ago
source link: https://github.com/osquery/osquery/pull/6956
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

The install paths for Linux have changed since the last time the docs were accurate, so I've tried to remedy that.

mike-myers-tob

changed the title Update the Linux install steps and package description

Update the Linux install steps and package listing

on Feb 19, 2021

Copy link

Member

Author

mike-myers-tob commented on Feb 19, 2021

Sanity check me here, because it seems like the service startup scripts also do not know to find osqueryd in /usr/local/bin despite the fact that CPack built the TGZ package this way. Was it the package that was incorrect, not the docs and the scripts?

Copy link

Member

Smjert commented on Feb 20, 2021

Sanity check me here, because it seems like the service startup scripts also do not know to find osqueryd in /usr/local/bin despite the fact that CPack built the TGZ package this way. Was it the package that was incorrect, not the docs and the scripts?

The TGZ uses the prefix directly from CMAKE_INSTALL_PREFIX which by default is /usr/local; the RPM and DEB packages though change that prefix to be /usr.

Copy link

Contributor

@directionless directionless left a comment

I suspect the docs could use a much deeper overhaul. but this looks like a small improvement

Copy link

Member

Author

mike-myers-tob commented on Feb 22, 2021

I suspect the docs could use a much deeper overhaul. but this looks like a small improvement

Many small improvements over time add up, is my hope.

But back to @Smjert 's comment: which is the "correct" or standard place to install osquery on Linux? I'd like to change the docs here to mention the install path prefix CMake thing, and then make a note that it's configurable.

Copy link

Member

Smjert commented on Feb 22, 2021

edited

I suspect the docs could use a much deeper overhaul. but this looks like a small improvement

Many small improvements over time add up, is my hope.

But back to @Smjert 's comment: which is the "correct" or standard place to install osquery on Linux? I'd like to change the docs here to mention the install path prefix CMake thing, and then make a note that it's configurable.

The default we have for packages is /usr (and it's the default that the packaging system set itself) because packages are normally expected to install under that.
/usr/local is for things installed out of the packaging system, like via scripts or via make install after compilation, which is why the default is in fact /usr/local for CMake too.
Keep in mind that CMAKE_INSTALL_PREFIX is only used at install time when either you manually call the install target or CPack calls the install target to prepare the package.
CPACK_PACKAGING_INSTALL_PREFIX is what chooses the prefix used by the package itself when installing.

Copy link

Contributor

directionless commented on Feb 22, 2021

There's a reasonable argument that we should move to /opt but I think that's out of scope here.

Copy link

Member

Author

mike-myers-tob commented on Feb 22, 2021

Ok, I believe the changes I made are now accurate. Thanks for the clarification!

directionless

merged commit d80bb56 into

osquery:master on Feb 23, 2021

11 checks passed

mike-myers-tob

deleted the mike/docs-fix-linux-install-steps branch

10 months ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK