binarycaching: Add NuGet timeout configuration entry by ekilmer · Pull Request #...
source link: https://github.com/microsoft/vcpkg-tool/pull/95
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
New issue
binarycaching: Add NuGet timeout configuration entry #95
Merged
Merged
binarycaching: Add NuGet timeout configuration entry #95
Conversation
Related to this issue microsoft/vcpkg#18483
As mentioned in the issue, ideally this timeout value could be configurable, but I'm not sure the best way to approach that in this code base. Help would be greatly appreciated!
Needs the extra second due to some potential issue with how NuGet calculates the timeout:
https://jfrog.com/knowledge-base/how-to-resolve-nuget-push-failures-after-5-minutes-even-though-timeout-value-is-set-as-greater-than-5-minutes-300-seconds/
Thanks for the PR!
I think we will eventually want this setting to come through the binary caching configuration string. To preserve our ability to fuse multiple NuGet calls together, I think this means it will need to come from a separate entry:
nuget,<url1>;nuget,<url2>;nugettimeout,3601
we will eventually want this setting to come through the binary caching configuration string
Just to confirm: You are referencing the valid source strings section and VCPKG_BINARY_SOURCES environment variable/--binarysource CLI option in the documentation on binary caching, and adding a new keyword nugettimeout?
If so, that makes sense to me! Thank you.
@ras0219-msft I've tried implementing a solution to what you described. I'd appreciate a review when you get a chance. Thank you!
This looks really good to me, thanks for making this PR!
Could you also add the new documentation to docs/users/binarycaching.md?
Could you also add the new documentation to
docs/users/binarycaching.md?
I'd be happy to! Just one question, how does that work? It looks like that file lives in the main vcpkg repo, and a PR to update the doc should also bump the vcpkg-tool to a commit that has this PR merged. But a bump to the vcpkg-tool version look like it requires a release (so that Windows users can download a pre-built executable).
It also looks like there is now a conflict with binarycaching.cpp file. I will try to fix that today at some point.
changed the title binarycaching: Default NuGet push timeout to one hour
binarycaching: Add NuGet timeout configuration entry
Ah, you're absolutely right. Sorry for my confusion! Still getting used to the split repos I suppose :)
Thanks again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No one assigned
None yet
No milestone
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK