5

libff: fix build on aarch64 by arcz · Pull Request #150850 · NixOS/nixpkgs · Git...

 2 years ago
source link: https://github.com/NixOS/nixpkgs/pull/150850
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Copy link

Member

arcz commented 17 days ago

Motivation for this change

Two additional cmake options are needed for this library to build on aarch64. Additionally, the versioning changed, 1.0.0 is now 0.2.1 (more on that here https://github.com/scipr-lab/libff/releases/tag/v0.2.1).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK