Handle non-integer const generic parameters in debuginfo type names. by michaelw...
source link: https://github.com/rust-lang/rust/pull/87082
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
This PR fixes an ICE introduced by #85269 which started emitting const generic arguments for debuginfo names but did not cover the case where such an argument could not be evaluated to a flat string of bits.
The fix implemented in this PR is very basic: If try_eval_bits() fails for the constant in question, we fall back to generating a stable hash of the constant and emit that instead. This way we get a (virtually) unique name and side step the problem of generating a string representation of a potentially complex value.
The downside is that the generated name will be rather opaque. E.g. the regression test adds a function const_generic_fn_non_int<()> which is then rendered as const_generic_fn_non_int<{CONST#fe3cfa0214ac55c7}>. I think it's an open question how to deal with this more gracefully.
I'd be interested in ideas on how to do this better.
r? @wesleywiser
cc @dpaoliello (do you see any problems with this approach?)
cc @Mark-Simulacrum & @nagisa (who I've seen comment on debuginfo issues recently -- anyone else?)
Fixes #86893
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK