7

[win7] Remove theme screen from new user onboarding

 3 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1707140
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client
Closed Bug 1707140 Opened 24 days ago Closed 18 days ago

[win7] Remove theme screen from new user onboarding

Categories

(Firefox :: Messaging System, enhancement, P1)

Firefox ▾
Messaging System ▾

Unspecified

Windows 7

Tracking

(bug has been fixed and VERIFIED)

VERIFIED FIXED

90 Branch

Iteration:

90.1 - Apr 19 - May 2

Tracking Status firefox89 --- verified firefox90 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-onboarding] [proton-uplift])

To avoid bug 1702480, don't have new users pick a theme. With only a single step after the initial screen, maybe steps should be hidden?

Iteration: --- → 90.1 - Apr 19 - May 2
Priority: -- → P1
Whiteboard: [proton-onboarding]

We can reuse bug 1703327's prepareContentForReact to remove the theme screen

Assignee: nobody → edilee
Depends on: 1703327
No longer blocks: 1707141

Use prepareContentForReact to remove any screen that uses theme tiles. Only show steps if there's more than 1 step.

Ed, do you want to uplift it?

Flags: needinfo?(edilee)

Comment on attachment 9218824 [details]
Bug 1707140 - [win7] Remove theme screen from new user onboarding r?pdahiya

Beta/Release Uplift Approval Request

  • User impact if declined: New windows 7 users see a theme selection screen making bug 1702480 more common
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Go to about:welcome
  1. See 2 screens (intro and import - no themes) and no step indicator
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Slight behavior change removing 3rd screen for windows 7
  • String changes made/needed: none
Flags: needinfo?(edilee)
Attachment #9218824 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Whiteboard: [proton-onboarding] → [proton-onboarding] [proton-uplift]

Comment on attachment 9218824 [details]
Bug 1707140 - [win7] Remove theme screen from new user onboarding r?pdahiya

Mitigation for bug 1702480, with tests and a testing plan for QA, approved for 89 beta 8, thanks.

Attachment #9218824 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I have verified this enhancement and I can confirm the "Themes" screen from the new users Onboarding page is no longer displayed.

Verified using the latest Firefox Nightly (90.0a1 - Build ID: 20210504092024) installed on Windows 7 x64.

I have verified this enhancement and I can confirm the "Themes" screen from the new users Onboarding page is no longer displayed.

Verified using the latest Firefox Beta (89.0b8 - Build ID: 20210504185920) installed on Windows 7 x64.

You need to log in before you can comment on or make changes to this bug.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK