Skeleton UI needs updating to Proton tab style
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1695674
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Skeleton UI needs updating to Proton tab style
Categories
(Firefox :: Theme, defect, P3)
Tracking
(bug RESOLVED as FIXED)
89 Branch
People
(Reporter: jaws, Assigned: dthayer)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-tabs-bar])
During startup the Skeleton UI shows the Photon tab shape. This will need to be updated to show the Proton (disconnected) tab shape before we ship Proton in Firefox 89.
Doug, is this something you can look in to?
Yup! It's already in our plans - just didn't have a bug yet. So thank you! Do you think the Proton designs are stable enough now to develop against?
Yes, they are stable enough now to develop against. Thanks!
We specify our colors like 0xrrggbb, but CreateSolidBrush expects a
color created with the RGB macro, which actually arranges it as
0xbbggrr. This change has us use the RGB macro to give a color when
creating the brush.
Depends on D107944
This causes them to match the figma mocks, not the currently implemented
colors.
Depends on D107945
We discussed at our MR1 product experience review that we should handle skeleton UI / MR1 interdependencies as follows:
- Skeleton UI availability should not block shipping MR1
- Skeleton UI should not ship until this bug is resolved
Can I please have a status update here? Per Comment 6 Skeleton UI won't block MR1 but should not make it to Beta if this bug is not resolved.
Waiting on review from emalysz. Throwing the needinfo her way, though I know she's looking at it as we talked about it yesterday. I don't have any worries about this landing very shortly.
We'll make sure to land this patch later today before soft freeze
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK