5

Move check for error in impl header outside of reporting by compiler-errors · Pu...

 5 months ago
source link: https://github.com/rust-lang/rust/pull/122894
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Move check for error in impl header outside of reporting #122894

Conversation

Fixes #121006

r? lcnr

test location kinda sucks, can move it if needed

lcnr reacted with heart emoji

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 22, 2024

@@ -0,0 +1,15 @@

//@ compile-flags: -Znext-solver

Contributor

Suggested change
// Regression test for #121006.

Contributor

also: slightly minimized

trait ToUnit<'a> {
    type Unit;
}

impl<T> ToUnit for T {}
//~^ ERROR implicit elided lifetime not allowed here

trait Overlap {}
impl<U> Overlap for fn(U) {}
impl Overlap for for<'a> fn(<() as ToUnit<'a>>::Unit) {}

fn main() {}

Please move it to the general coherence folder, it also affects the old solver (and use revisions)

Contributor

@bors r+ rollup

Contributor

📌 Commit 5333f2a has been approved by lcnr

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Apr 5, 2024

bors

merged commit cb6a1c8 into

rust-lang:master

Apr 5, 2024

11 checks passed

rustbot

added this to the 1.79.0 milestone

Apr 5, 2024

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Apr 5, 2024

Oneirical

added a commit to Oneirical/rust that referenced this pull request

Apr 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lcnr

lcnr left review comments
Assignees

lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

ICE: downgrade_to_delayed_bug: cannot downgrade Warning to DelayedBug: not an error

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK