10

Validate there are no critical call edges in optimized MIR by tmiasko · Pull Req...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/118075
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

No description provided.

Collaborator

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 19, 2023

Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Member

There is a typo in the last commit message: corotuine -> coroutine

tmiasko reacted with thumbs up emoji

tmiasko

changed the title Validate that critical call edges are split in optimized MIR

Validate there are no critical call edges in optimized MIR

Nov 19, 2023

Contributor

@bors r+

Contributor

📌 Commit 329d015 has been approved by cjgillot

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 25, 2023

Contributor

⌛ Testing commit 329d015 with merge 4fffe65...

Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Contributor

💔 Test failed - checks-actions

bors

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Nov 25, 2023

Contributor

Author

@bors retry

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 25, 2023

Contributor

⌛ Testing commit 329d015 with merge fad6bb8...

Contributor

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing fad6bb8 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

Nov 25, 2023

bors

merged commit fad6bb8 into

rust-lang:master

Nov 25, 2023

12 checks passed

Collaborator

Finished benchmarking commit (fad6bb8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

Results

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.85s -> 674.747s (-0.02%)
Artifact size: 313.30 MiB -> 313.31 MiB (0.00%)

tmiasko

deleted the validate-critical-call-edges branch

November 26, 2023 11:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

cjgillot

cjgillot left review comments
Assignees

cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

None yet

7 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK