15

Use an absolute path to the NUL device by ChrisDenton · Pull Request #118060 · r...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/118060
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

While a bare "NUL" should be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly.

This will also set a good example for people copying std code.

r? libs

rustbot

added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

labels

Nov 19, 2023

Member

@bors r+ rollup

Contributor

📌 Commit 3a486c1 has been approved by thomcc

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 24, 2023

bors

merged commit b2d6480 into

rust-lang:master

Nov 24, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Nov 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

No reviews

Assignees

thomcc

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK