6
fix: Dedup duplicate crates with differing origins in CrateGraph construction by...
source link: https://github.com/rust-lang/rust-analyzer/pull/15754
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Partially fixes #15656 . Until now the condition for deduplication in crate graphs were the strict equality of two crates. One problem that arises from this is that in certain conditions when we see the same crate having different CrateOrigins the first occurrence would be kept. This approach however results in some unwanted results such as making renaming forbidden as this has been recently only made available for local crates. The given example in #15656 can still not be resolved with this PR as that involves taking inconsistencies between dependencies into consideration. This will be addressed in a future PR.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK