7

refactor(toml): Better abstract inheritance details by epage · Pull Request #130...

 9 months ago
source link: https://github.com/rust-lang/cargo/pull/13021
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

refactor(toml): Better abstract inheritance details #13021

Conversation

Contributor

There is no reason that the caller for inheriting needs to know the details of the inner types doing inheritance.

Collaborator

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2023

Member

Thanks!

@bors r+

Collaborator

📌 Commit 7bd5aa3 has been approved by weihanglo

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2023

Collaborator

⌛ Testing commit 7bd5aa3 with merge 7677f26...

Collaborator

💥 Test timed out

bors

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Nov 22, 2023

Contributor

Author

@bors retry

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2023

Collaborator

⌛ Testing commit 7bd5aa3 with merge 463f307...

Collaborator

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 463f307 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

weihanglo

weihanglo approved these changes
Labels
A-manifest Area: Cargo.toml issues S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK