6

When failing to import `core`, suggest `std` by estebank · Pull Request #118065...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/118065
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Contributor

No description provided.

Collaborator

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 19, 2023

Member

@TaKO8Ki TaKO8Ki

left a comment

I left one suggestion. After addressing that r=me

TaKO8Ki

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2023

Contributor

Author

@bors r=TaKO8Ki

Contributor

📌 Commit ec50f1c has been approved by TaKO8Ki

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Nov 22, 2023

Contributor

⌛ Testing commit ec50f1c with merge 360bafa...

Contributor

☀️ Test successful - checks-actions
Approved by: TaKO8Ki
Pushing 360bafa to master...
1 similar comment

bors

added merged-by-bors This PR was explicitly merged by bors

labels

Nov 23, 2023

bors

merged commit 360bafa into

rust-lang:master

Nov 23, 2023

12 checks passed

Collaborator

Finished benchmarking commit (360bafa): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.393s -> 677.231s (0.42%)
Artifact size: 313.69 MiB -> 313.70 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

TaKO8Ki

TaKO8Ki left review comments
Assignees

TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

None yet

5 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK