fix: allow more kinds of if let patterns in guarded return assist by rmehri01 ·...
source link: https://github.com/rust-lang/rust-analyzer/pull/15698
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
Removes the checks that require the pattern to be a tuple struct with exactly 1 field that is unqualified and has an identifier pattern in it. I'm not sure if there should be more checks in place but they seem unnecessary now?
Closes #15695
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
These are indeed unnecessary now that we are emitting let ... else ... here, good catch
Member
|
Thanks! |
Collaborator
|
☀️ Test successful - checks-actions |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
Convert to guarded return does not work with many kinds of if let
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK